Get Free Trial
Get Free Trial

Missing i18n on toolbar new currency format options

Projet TCD asked on May 22, 2019

Hello,
Please be aware that some strings were left hard-coded in flexmonster.toolbar.js (including in v2.7.6) and it currently does not allow localization:

// positive currency_format
var row = createFormattingItem("Positive currency format");
var select = self.createSelect();
var positiveCurrencyFormat = select.select;
initializeSelect(positiveCurrencyFormat, positiveCurrencyFormatConfig);
row.appendChild(select);

// negative currency_format
var row = createFormattingItem("Negative currency format");
var select = self.createSelect();
var negativeCurrencyFormat = select.select;
initializeSelect(negativeCurrencyFormat, negativeCurrencyFormatConfig);
row.appendChild(select);

I think it should be:

// positive currency_format
var row = createFormattingItem(Labels.positive_currency_format);
var select = self.createSelect();
var positiveCurrencyFormat = select.select;
initializeSelect(positiveCurrencyFormat, positiveCurrencyFormatConfig);
row.appendChild(select);

// negative currency_format
var row = createFormattingItem(Labels.negative_currency_format);
var select = self.createSelect();
var negativeCurrencyFormat = select.select;
initializeSelect(negativeCurrencyFormat, negativeCurrencyFormatConfig);
row.appendChild(select);

Where we named the new labels “positive_currency_format” and “negative_currency_format”.
 
Additionally, I think it should be added to https://github.com/flexmonster/pivot-localizations/blob/master/en.json
 
Thank you & best regards,

2 answers

Public
Vera Didenko Flexmonster May 23, 2019

Hello, 
 
Thank you for pointing this out and sharing your ideas with us.
 
Our team agrees that labels for positive and negative currency formats should be added in order for them to be easily localized.
 
We will add necessary changes to the component as well as to our pivot-localizations GitHub repository shortly.
The fix will be available in the minor release version 2.7.8 of Flexmonster with the ETA 18th of June.
 
Feel free to contact us in case of any questions.
 
Best Regards,
Vera

Public
Vera Didenko Flexmonster June 18, 2019

Hello, 

We are glad to announce that we have added two new localization labels: positive_currency_format and negative_currency_format. Get the updated localization on our GitHub. (https://github.com/flexmonster/pivot-localizations/).

Please let us know if everything works fine.

We are looking forward to hearing from you.

Best Regards,

Vera

Please login or Register to Submit Answer